MODUL: Staffelpreise gleich für alle Gruppen

[AGI]

Hallo Timm,

vielen Dank für deine unermüdliche Arbeit hier im Forum.

Ich habe die Erweiterung für die Shopversion 2.0.5.1 angepasst.
Die Änderungsanweisungen sind quasi die gleichen. Nur sind die beiliegenden Vergleichsdateien jetzt anders.

Viele Grüße
Andreas

[EDIT Tomcraft 29.04.2020: Modul in Beitrag 1 ergänzt.]

[Timm]

Vielen Dank Andreas.

Gruß Timm

[noRiddle (revilonetz)]

Bin hier gerade zufällig drüber gestolpert.
In der xtcPrice-Klasse gäbe es einen Hook als Klassenerweiterung.
Das würde die Änderungen auf die product-Klasse beschränken.

Upps, nö, doch nicht...

Gruß,
noRiddle

[Timm]

Moin Andreas

In Shopversion 2.0.7.2 mit PHP 8.1 kommt es zu folgenden warnings, wenn man auf Module-Systemmodule klickt.

Code: XML  [Auswählen]

[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Constant MODULE_XTCPRICE_AGIPREISUEBERNAHME_STATUS_TITLE already defined in File: /var/www/clients/client1/web5/web/includes/modules/xtcPrice/agiPreisuebernahme.php on Line: 50        {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #0 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 200   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #1 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 243   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #2 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 426   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      WARNING found for URL: /admin/modules.php?set=xtcPrice  {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Constant MODULE_XTCPRICE_AGIPREISUEBERNAHME_STATUS_DESC already defined in File: /var/www/clients/client1/web5/web/includes/modules/xtcPrice/agiPreisuebernahme.php on Line: 51 {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #0 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 200   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #1 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 243   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #2 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 426   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      WARNING found for URL: /admin/modules.php?set=xtcPrice  {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Constant MODULE_XTCPRICE_AGIPREISUEBERNAHME_SORT_ORDER_TITLE already defined in File: /var/www/clients/client1/web5/web/includes/modules/xtcPrice/agiPreisuebernahme.php on Line: 52    {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #0 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 200   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #1 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 243   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #2 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 426   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      WARNING found for URL: /admin/modules.php?set=xtcPrice  {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Constant MODULE_XTCPRICE_AGIPREISUEBERNAHME_SORT_ORDER_DESC already defined in File: /var/www/clients/client1/web5/web/includes/modules/xtcPrice/agiPreisuebernahme.php on Line: 53     {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #0 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 200   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #1 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 243   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #2 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 426   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      WARNING found for URL: /admin/modules.php?set=xtcPrice  {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Constant MODULE_XTCPRICE_AGIPREISUEBERNAHME_BASE_GROUP_TITLE already defined in File: /var/www/clients/client1/web5/web/includes/modules/xtcPrice/agiPreisuebernahme.php on Line: 54    {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #0 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 200   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #1 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 243   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #2 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 426   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      WARNING found for URL: /admin/modules.php?set=xtcPrice  {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Constant MODULE_XTCPRICE_AGIPREISUEBERNAHME_BASE_GROUP_DESC already defined in File: /var/www/clients/client1/web5/web/includes/modules/xtcPrice/agiPreisuebernahme.php on Line: 55     {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #0 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 200   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #1 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 243   {}      {}
[2022-10-23 19:53:05]   [warning]       [modified]      [pid:5632]      Backtrace #2 - /var/www/clients/client1/web5/web/admin/modules.php called at Line 426   {}      {}

Die entsprechende Stelle:

Code: PHP  [Auswählen]

function keys() {
        define($this->name.'_STATUS_TITLE', TEXT_DEFAULT_STATUS_TITLE);
        define($this->name.'_STATUS_DESC', TEXT_DEFAULT_STATUS_DESC);
        define($this->name.'_SORT_ORDER_TITLE', TEXT_DEFAULT_SORT_ORDER_TITLE);
        define($this->name.'_SORT_ORDER_DESC', TEXT_DEFAULT_SORT_ORDER_DESC);
        define($this->name.'_BASE_GROUP_TITLE', 'Basis Kundengruppe');
        define($this->name.'_BASE_GROUP_DESC', 'Die Preise für alle Shop-Kunden werden aus dieser Kundengruppe geholt');

Falls du mal Zeit dafür hast, wäre es toll, wenn du dir das anschaust.

Grüße Timm

[noRiddle (revilonetz)]

Mache einfach in der function keys()  bei den Einträgen jeweils ein

Code: PHP  [Auswählen]

defined($this->name.'_XXXXX') OR

davor.
"XXXXX" steht natürlich für den jeweiligen Konstantenteil und muß mit diesem ersetzt werden.

Gruß,
noRiddle

[Timm]

Moin Oli

Danke dir funktioniert so:

Code: PHP  [Auswählen]

function keys() {
        defined($this->name.'_STATUS_TITLE') OR define($this->name.'_STATUS_TITLE', TEXT_DEFAULT_STATUS_TITLE);
        defined($this->name.'_STATUS_DESC') OR define($this->name.'_STATUS_DESC', TEXT_DEFAULT_STATUS_DESC);
        defined($this->name.'_SORT_ORDER_TITLE') OR define($this->name.'_SORT_ORDER_TITLE', TEXT_DEFAULT_SORT_ORDER_TITLE);
        defined($this->name.'_SORT_ORDER_DESC') OR define($this->name.'_SORT_ORDER_DESC', TEXT_DEFAULT_SORT_ORDER_DESC);
        defined($this->name.'_BASE_GROUP_TITLE') OR define($this->name.'_BASE_GROUP_TITLE', 'Basis Kundengruppe');
        defined($this->name.'_BASE_GROUP_DESC') OR define($this->name.'_BASE_GROUP_DESC', 'Die Preise für alle Shop-Kunden werden aus dieser Kundengruppe geholt');

ich muss nur korrigieren, dass es nicht bei den Systemmodulen passierte, sondern beim durchklicken der Klassenerweiterungen.

Gruß Timm

[Timm]

Moin

Ich hab das Paket mal an Shopversion 2.0.7.2 angepasst.

Folgende Änderungen:
- Zeilenangaben für Änderungen in der readme.txt angepasst
- neue Dateien eingepflegt und angepasst in Ordner backup und changed
- PHP 8 Fix siehe einen Beitrag vorher und einen Umlautfehler bereinigt in Ordner new

ACHTUNG:
Paket gilt nur für eine frische 2.0.7.2 Version. Es wurde später mindestens die /includes/classes/product.php angepasst zb durch das Changeset aus Ticket #2273.

Gruß Timm

[EDIT Tomcraft 13.10.2023: Modul in Beitrag 1 ergänzt.]